Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic data primitives block builder test framework #13522

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: generic data primitives block builder test framework #13522

wants to merge 2 commits into from
+27 −22

Conversation

hoank101
Copy link
Contributor

Closes #13239

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 23, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #13522 will not alter performance

Comparing hoank101:feat/13239 (300c03a) with main (ec21e89)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main hoank101:feat/13239 Change
🆕 `prefix set preload size: 1000 input size: 1000 BTreeSet with BTreeSet:range lookup`
🆕 `prefix set preload size: 1000 input size: 1000 BTreeSet with Iterator:any lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
⁉️ `prefix set preload size: 1000 input size: 997 BTreeSet with BTreeSet:range lookup`
⁉️ `prefix set preload size: 1000 input size: 997 BTreeSet with Iterator:any lookup`
⁉️ `prefix set preload size: 1000 input size: 997 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 997 Vec with custom cursor lookup`

@hoank101
Copy link
Contributor Author

hi @emhane please help me review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic data primitives block builder test framework
1 participant
@hoank101